Address correctness issues in Supply Chain pattern #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponylang-main
added
the
discuss during sync
A user pointed out that we weren't address the fact that `File` can fail and that you need to check `errno()` to see if it worked. This makes the pattern incomplete and misleading. When I was addressing this, I noticed that when I originally wrote the pattern, I was trying to write the temp directory without creating a file in it. Both issues have been addressed in this update. Closes #71
|
@rhagenson can you carve out some time to do a copy edit review? |
rhagenson
requested changes
Jan 11, 2024
Co-authored-by: Ryan A. Hagenson <[email protected]>
Co-authored-by: Ryan A. Hagenson <[email protected]>
Co-authored-by: Ryan A. Hagenson <[email protected]>
jemc
approved these changes
Jan 16, 2024
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user pointed out that we weren't address the fact that
Filecan fail and that you need to checkerrno()to see if it worked. This makes the pattern incomplete and misleading.When I was addressing this, I noticed that when I originally wrote the pattern, I was trying to write the temp directory without creating a file in it.
Both issues have been addressed in this update.
Closes #71