Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a 'recreate compound primary key' issue #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix a 'recreate compound primary key' issue #117

wants to merge 1 commit into from

Conversation

mybjlife
Copy link

Problems solved in this PR

Issue #114

Changes proposed in this PR

Also hide metadata for dropped primary key before executing physical DDL operations.

Tests

Added a new test case: AlterTableTest.testAlterTableDropAddCompPrimaryKey()

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mybjlife mybjlife changed the title Fix a 'recreate compound primary key' issue. Fix a 'recreate compound primary key' issue Dec 15, 2022
joeCarf
joeCarf approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeCarf joeCarf joeCarf approved these changes

Assignees
No one assigned
Labels
ready for test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mybjlife @CLAassistant @joeCarf @Oldbread3