Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix invalid list collection in expression engine #19191

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix: Fix invalid list collection in expression engine #19191

merged 2 commits into from
Oct 11, 2024

Conversation

ritchie46
Copy link
Member

fixes #19173

Also makes get_list_builder work for Object types and thus is now infallible.

I can get rid of the extra if len == 0 branch, but must fix some IR bugs to do that. Will follow up.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 11, 2024
@ritchie46 ritchie46 merged commit 0870a5d into main Oct 11, 2024
23 checks passed
@ritchie46 ritchie46 deleted the agg branch October 11, 2024 09:26
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 87.30159% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.66%. Comparing base (f8a7041) to head (758a016).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-expr/src/expressions/apply.rs 68.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19191      +/-   ##
==========================================
- Coverage   79.67%   79.66%   -0.02%     
==========================================
  Files        1532     1532              
  Lines      209150   209132      -18     
  Branches     2416     2416              
==========================================
- Hits       166648   166598      -50     
- Misses      41956    41988      +32     
  Partials      546      546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when applying .group_by().agg() on an empty dataframe.
1 participant