Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set library prefix from command line #4763

Closed
grandinj opened this issue Nov 7, 2024 · 4 comments
Closed

Cannot set library prefix from command line #4763

grandinj opened this issue Nov 7, 2024 · 4 comments

Comments

@grandinj
Copy link

grandinj commented Nov 7, 2024

i.e.

cmake .. -DLIBPREFIX=foo

does not work.

Ideally POCO should be using the normal CMake stuff instead of re-inventing the wheel, but at least overriding should work.

@grandinj grandinj added the bug label Nov 7, 2024
@aleks-f aleks-f added this to the Release 1.14.0 milestone Nov 8, 2024
@matejk
Copy link
Contributor

matejk commented Nov 11, 2024

@grandinj, what do you mean by "POCO should be using the normal CMake stuff instead of re-inventing the wheel"?

Was this reproduced with the latest code from main?

@grandinj
Copy link
Author

Hi @matejk

Thanks for responding. Yes, I tested with the latest code from main.

Possibly I am mistaken, or using the cmake build wrong, so feel free to close this bug if I am being an idiot :-)

As far as I understand, CMake already has:

https://cmake.org/cmake/help/v3.17/variable/CMAKE_SHARED_LIBRARY_PREFIX.html

Which is what I meant by "re-inventing the wheel".

What I was trying to do, was to remove the "lib" prefix that is inserted for library names on Linux.

@matejk
Copy link
Contributor

matejk commented Nov 12, 2024

Poco does not use LIBPREFIX in CMake files. They are only used when building with make.

Did you try setting CMAKE_SHARED_LIBRARY_PREFIX when configuring CMake?

@grandinj
Copy link
Author

Did you try setting CMAKE_SHARED_LIBRARY_PREFIX when configuring CMake?

Yes, I tried
cmake .. -DCMAKE_SHARED_LIBRARY_PREFIX=xxx
but it always used "lib".

Hmmm, some googling finds me this:
https://discourse.cmake.org/t/how-to-use-cmake-shared-library-prefix-in-command-line/11410

So apparently this is a CMake issue, not a Poco issue.

Thanks for checking, I will close this.

@matejk matejk added the invalid label Nov 12, 2024
@matejk matejk removed this from the Release 1.14.0 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants