Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): improve Cache example #41

Merged
merged 2 commits into from
May 7, 2022
Merged

Conversation

nelson6e65
Copy link
Contributor

@nelson6e65 nelson6e65 commented May 7, 2022

Dynamically detect the Store directory and use the latest GitHub actions.

I tested here: https://github.com/elegantech/firebase-odm/runs/6331495061?check_suite_focus=true#step:7:12

This should replace #39 and resolve my question in #8 (comment)

This also fixes the previous workflow example.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@KSXGitHub KSXGitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one last question/complaint. Answer/resolve it, and it would be good to merge.

README.md Outdated Show resolved Hide resolved
Dynamically detect the Store directory and use the latest GitHub actions.
README.md Outdated Show resolved Hide resolved
@KSXGitHub KSXGitHub merged commit 57b9359 into pnpm:master May 7, 2022
@nelson6e65 nelson6e65 deleted the patch-1 branch May 7, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants