Only check packageManager if it actually specifies pnpm
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We upgrade to version 4 and started seeing the following weird error:
```
Error: Multiple versions of pnpm specified:
Error: Error: Multiple versions of pnpm specified:
- version 9 in the GitHub Action config with the key "version"
- version [email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e in the package.json with the key "packageManager"
Remove one of these versions to avoid version mismatch errors like ERR_PNPM_BAD_PM_VERSION
- version 9 in the GitHub Action config with the key "version"
- version [email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e in the package.json with the key "packageManager"
```
Even though we don't specify `packageManager` in `package.json` explicitly.
Either way this change seems like an improvement to do `pnpm` version validation only if it's actually `pnpm`.
I don't understand, if you don't have the field in package.json, how do you get the error? |
|
Found the issue. There was some problem with a working dir. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We upgrade to version 4 and started seeing the following weird error:
Even though we don't specify
packageManagerinpackage.jsonexplicitly.Either way this change seems like an improvement to do
pnpmversion validation only if it's actuallypnpm.