Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🕵️‍♂️ Recheck what will happen if we update CLI to v7 #81

Closed
Adam-it opened this issue Sep 2, 2023 · 2 comments · Fixed by #108
Closed

🕵️‍♂️ Recheck what will happen if we update CLI to v7 #81

Adam-it opened this issue Sep 2, 2023 · 2 comments · Fixed by #108
Assignees
@Adam-it
Labels
dependencies Pull requests that update a dependency file ⭐ enhancement New feature or request ✏️prototype 👨‍💻work in progress I am working on it
Milestone
v2.1

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Sep 2, 2023

🎯 Aim

The aim is to investigate what changes are needed and how the extension will behave if we update CLI to v7. In this major release CLI was refactored to esm modules.
@Adam-it Adam-it added the ⭐ enhancement New feature or request label Sep 2, 2023
@Adam-it Adam-it added this to the v2.0 milestone Sep 2, 2023
@Adam-it Adam-it self-assigned this Sep 2, 2023
@Adam-it Adam-it added the 👨‍💻work in progress I am working on it label Sep 2, 2023
@Adam-it Adam-it modified the milestones: v2.0, 2.1 Sep 7, 2023
@Adam-it Adam-it mentioned this issue Oct 7, 2023
Closed
@Adam-it
Copy link
Contributor Author

Adam-it commented Oct 7, 2023

As of now VS Coded extensions does not support es modules as internally it uses electron version 25.
Es modules are supported from version 28 of electron. It is not still sure when VS Coded will be updated.

As of now we need to make a local copy of CLI for M365 withe reverted change to cjs.
Along the way we may clear the npm package to include only the commands that are used in the extension

@Adam-it Adam-it added dependencies Pull requests that update a dependency file ✏️prototype labels Oct 7, 2023
@Adam-it Adam-it mentioned this issue Oct 12, 2023
Merged
9 tasks
Adam-it added a commit that referenced this issue Oct 17, 2023
@Adam-it
Refactor CLI for M365 dependency to local version and bug fixes. Closes…
f97a3c0 
…: #103 #82 #81 (#108)

## 🎯 Aim

The aim of this PR is to refactor the extension to use local version of
CLI for Microsoft365 that was reverted to cjs. Mainly due to the fact es
modules are still not supported by VS Code extensions.
Along the way some small bug fixes were included like reading sample
data from main branch or allowing to login immediately after logout

## ✅ What was done

- [X] Refactored pipelines to replace npm package with local cleaned-up
version of CLI
- [X] Refactored pipelines to use node v18
- [X] Adds new pipeline to create artifact with package
- [X] Bug fix of Login after logout
- [X] Bug fix to read sample data from main
- [X] Adds support for SPFx 1.18.0 (upgrade)
- [x] Validate environment will validate node 16-18
- [x] Update scaffolding process (different flow for node 16 and 18, new
ACEs templates)
- [x] Prepare pre-release 

## 🔗 Related issue

Closes: #103 
Closes:  #82 
Closes:  #81
@Adam-it
Copy link
Contributor Author

Adam-it commented Oct 17, 2023

closing this as done and the support of es modules will be tracked in
#114

@Adam-it Adam-it closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adam-it Adam-it

Labels
dependencies Pull requests that update a dependency file ⭐ enhancement New feature or request ✏️prototype 👨‍💻work in progress I am working on it
Projects
None yet
Milestone
v2.1
1 participant
@Adam-it