💡 [Feature]: extend CLI command logs with full name and options passed #283
Assignees
Labels
⭐ enhancement
New feature or request
💪 good first issue
Good for newcomers
hacktoberfest
👨💻work in progress
I am working on it
Milestone
Comments
Adam-it
added
⭐ enhancement
|
lets keep this on hold until this issue is resolved #295 |
Adam-it
added
hacktoberfest
and removed
🤚 on hold
lets not care about it. We may always document that we are using older version of CLI under the hood |
|
I would like to work on this problem |
Adam-it
added
👨💻work in progress
All yours. |
This was referenced Sep 30, 2024
Adam-it
pushed a commit
that referenced
this issue
Oct 4, 2024
…313) ## 🎯 Aim Adding the m365 prefix: The m365 prefix is now included before every CLI command, ensuring that the logged commands accurately reflect what is run in the terminal. Logging CLI command options: The PR also includes the functionality to log the options passed with each command, providing better transparency and guidance for developers who want to understand the equivalent terminal commands for SPFx Toolkit features. However, the functionality to set json as the default output for all commands was not implemented, as there are parts of the code that use other output formats, such as md (Markdown). Changing the default output to json globally could break those functionalities.  ## 📷 Result   ## 🔗 Related issue Closes: #283
|
PR merged. |
Adam-it
pushed a commit
that referenced
this issue
Oct 19, 2024
…313) ## 🎯 Aim Adding the m365 prefix: The m365 prefix is now included before every CLI command, ensuring that the logged commands accurately reflect what is run in the terminal. Logging CLI command options: The PR also includes the functionality to log the options passed with each command, providing better transparency and guidance for developers who want to understand the equivalent terminal commands for SPFx Toolkit features. However, the functionality to set json as the default output for all commands was not implemented, as there are parts of the code that use other output formats, such as md (Markdown). Changing the default output to json globally could break those functionalities.  ## 📷 Result   ## 🔗 Related issue Closes: #283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🎯 Aim of the feature
Currently the logs for CLI commands are quite short
we are missing the
m365before every command and we do not print out the passed options that were used to run this command. This does not help as the actually idea behind this functionality was to provide guidance for developers what are the CLI commands that may use as equivalent to the SPFx Toolkit feature if they would rather use a terminal instead.We should fix it up.
In order to do that we should recheck the
tryExecuteCommandmethod inhttps://github.com/pnp/vscode-viva/blob/main/src/services/CliCommandExecuter.ts
We should add:
m365for every commandtext. IMO it should be alwaysjsonand we could then remove passing it in all placesThe text was updated successfully, but these errors were encountered: