Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1775 and #1760 #1781

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Fix for #1775 and #1760 #1781

wants to merge 7 commits into from

Conversation

wuxiaojun514
Copy link
Contributor

Q A
Bug fix? [ x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1775 #1760

What's in this Pull Request?

This pull request is to fix two issues on required field validation issues in Dynamic Form control
Dynamic Form has done huge refactoring on version 3.17. See pull request 1672 for detail

The root cause of issue #1760 is due to the initial value of newValue has been changed from "null" to "undefined". So I modified the related code to "undefined" as well.

Regarding #1775 , now changedValue won't use loaded item's value as initial value. So I added another check to compare with value when there is no new value on this field.

@6gal6ler6
Copy link
Contributor

@wuxiaojun514

Thanks for taking care of this issue!!!

@devspfx
Copy link

devspfx commented Mar 25, 2024

When will be this fix available? When we will have a new release?

@joelfmrodrigues
Copy link
Collaborator

Waiting for #1726

Migrate from Original Dev Branch
@devspfx
Copy link

devspfx commented Aug 28, 2024

@joelfmrodrigues any news about this issue? We hope to have a resolution

Merge from Main Dev Branch to my personal dev branch
Sync the latest dev branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants