Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Fixes #2652

Closed
wants to merge 4 commits into from
Closed

Multiple Fixes #2652

wants to merge 4 commits into from

Conversation

stokuri
Copy link

@stokuri stokuri commented Dec 15, 2022

Fixed Debug build dependencies

Type

  • Bug Fix
  • New Feature
  • Sample

What is in this Pull Request ?

@stokuri stokuri changed the title Fixed Debug build dependencies Multiple Fixes Dec 15, 2022
@KoenZomers
Copy link
Collaborator

Please next time file one type of change per PR to make it easier on us to validate this. Few questions:

  1. Do I understand your PR correctly that it needs the PR in PnP Framework to be merged first before this one can work? I see the PnP Framework one is currently still in draft.
  2. What problem are you trying to fix by updating the Build-Debug.ps1 file?

@stokuri
Copy link
Author

stokuri commented Jan 18, 2023

Please next time file one type of change per PR to make it easier on us to validate this. Few questions:

Sorry for not following this. I will be closing this PR and will create individual ones shortly.

  1. Do I understand your PR correctly that it needs the PR in PnP Framework to be merged first before this one can work? I see the PnP Framework one is currently still in draft.

yes, i have updated the PR and is open for review here -> pnp/pnpframework#825

  1. What problem are you trying to fix by updating the Build-Debug.ps1 file?

When building in debug, libraries from local PnPCoreSdkPath are getting ignored and the references are made to the official nightly builds.

@stokuri stokuri closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants