Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AIEducation Apps #43

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

apprauHiruka
Copy link

@apprauHiruka apprauHiruka commented Sep 29, 2023

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <[email protected]>

Put an x in all the items that apply ([x], without spaces), make notes next to any that haven't been addressed.

  • Bug fix?
  • New sample?
  • Related issues: fixes #X, partially #Y, mentioned in #Z
  • Needs API permissions?
  • Has other prerequisites? (E.g. requires a list, document library, etc.)

What's in this Pull Request?

Education has never been this efficient and innovative! Introducing the future of education with our AI-infused Microsoft Power Platform Student Management System. In this solution, we provide a number of features for educators and students to ease their work with embedded AI solutions and specially designed features. For students, the 'AI Education' app offers seamless access to courses, announcements, and assignment submissions. Experience AI-powered features like Language Translator, Summarizer and Assignments Assist, making learning more accessible and efficient. Teachers can simplify their workload with the 'AI Education Teachers' App,' enabling easy subject management, assignment grading, and even AI-generated assignments.

Checklist

This checklist is mostly useful as a reminder of small things that can easily be forgotten – it is meant as a helpful tool rather than hoops to jump through.

Put an x in all the items that apply ([x], no spaces), make notes next to any that haven't been addressed.

  • My pull request affects only ONE sample.
  • I have updated the README file.
  • My README has at least one static high-resolution screenshot (i.e. not a GIF)
  • My README contains complete setup instructions, including pre-requisites and permissions required

@Katerina-Chernevskaya
Copy link
Contributor

Hi @apprauHiruka,

Thank you for your submission! Your efforts are invaluable!
During reviewing and attempting to compile from the source code, I encountered a few minor hitches that require attention prior to merging:

  1. AI Education Teacher App issue:
    It appears that the 'Log in' button does not trigger any action. Upon investigation, it seems the 'OnSelect' property may not be configured properly. Could you please review and amend this?

  2. AI Education issue:
    While testing, the connector encountered an error (please refer to the attached screenshots for details). Could you please check if there are any prerequisites or certain parts of the source code that were overlooked?
    image
    image

  3. During the compilation process, I received a warning:

Following root components are not defined in customizations:
  Type='431', Id (or schema name)='GenericComponent-appr_course appr_courseicon'.
  Type='432', Id (or schema name)='GenericComponent-appr_course'.

While this isn't blocking issue, addressing it could enhance the overall code quality.

I believe these adjustments are minor and am confident that they can be resolved swiftly. Once these issues are addressed, I will be more than happy to conduct a retest and proceed with merging your PR.

Thank you once again for your invaluable contribution and looking forward to your revised submission.

Kind regards,
Katerina Chernevskaya

@apprauHiruka
Copy link
Author

Hi @Katerina-Chernevskaya,
Thank you for taking your valuable time to check the PR and letting me know about the issues. I'll look into those and fix them ASAP.

Cheers,
Hiruka Ranasinghe

@aprildunnam aprildunnam added the Needs Attention Something needs to be fixed with the PR before merging label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Attention Something needs to be fixed with the PR before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants