Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance aad o365group get #5348

Closed
wants to merge 24 commits into from
Closed

Enhance aad o365group get #5348

wants to merge 24 commits into from

Conversation

MathijsVerbeeck
Copy link
Contributor

Closes #4217

@milanholemans milanholemans added the pr-major PR for the next major release label Jul 25, 2023
@milanholemans
Copy link
Contributor

Thank you! We'll have a look at it ASAP!

@milanholemans milanholemans linked an issue Jul 25, 2023 that may be closed by this pull request
Update aad o365group get so that it returns only O365 groups, rather than all groups #4217
Closed
@milanholemans
Copy link
Contributor

Hi, @MathijsVerbeeck thank you for contributing to the next major release. Since this is a breaking change, could you please extend our v7 upgrade guidance with this breaking change?

Much appreciated! 🙏

@milanholemans milanholemans marked this pull request as draft July 26, 2023 23:19
@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review July 27, 2023 09:15
@milanholemans
Copy link
Contributor

Same here @MathijsVerbeeck, only change in the PR is the upgrade guidance.

@milanholemans milanholemans marked this pull request as draft July 29, 2023 21:46
@MathijsVerbeeck
Copy link
Contributor Author

Same here @MathijsVerbeeck, only change in the PR is the upgrade guidance.

Strange. Should be resolved!

@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review July 31, 2023 08:41
@Adam-it
Copy link
Contributor

Adam-it commented Aug 5, 2023

@MathijsVerbeeck also this PR will need a rebase with the latest v7 👍

@milanholemans milanholemans marked this pull request as draft August 5, 2023 10:56
@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review August 8, 2023 22:14
@milanholemans milanholemans self-assigned this Aug 9, 2023
milanholemans
milanholemans approved these changes Aug 12, 2023
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@milanholemans
Copy link
Contributor

Merged manually, thank you! 👏

@MathijsVerbeeck MathijsVerbeeck deleted the enhance-aad-o365group-get branch May 25, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milanholemans milanholemans milanholemans approved these changes

Assignees

@milanholemans milanholemans

Labels
pr-major PR for the next major release pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update aad o365group get so that it returns only O365 groups, rather than all groups
10 participants
@MathijsVerbeeck @milanholemans @Adam-it @waldekmastykarz @martinlingstuyl @nanddeepn @plamber @Saurabh7019 @SmitaNachan @arjunumenon