Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds command spo listitem attachment set #5347

Closed

Conversation

MathijsVerbeeck
Copy link
Contributor

Closes #5222

@MathijsVerbeeck MathijsVerbeeck changed the title Adds command `spo listitem attachment set´ Adds command spo listitem attachment set Jul 25, 2023
@milanholemans
Copy link
Contributor

Thank you, we'll try to review it ASAP!

Copy link
Contributor

@Jwaegebaert Jwaegebaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MathijsVerbeeck, would you mind updating your PR to utilize ESM? Here's a breakdown of the new changes:

@Jwaegebaert Jwaegebaert marked this pull request as draft September 3, 2023 16:27
@Jwaegebaert Jwaegebaert self-assigned this Sep 3, 2023
@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review September 4, 2023 09:07
Copy link
Contributor

@Jwaegebaert Jwaegebaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @MathijsVerbeeck, I've left a few pointers you can look at. Shouldn't be too much work 😄

@Jwaegebaert Jwaegebaert marked this pull request as draft September 8, 2023 18:53
@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review September 18, 2023 10:41
Copy link
Contributor

@Jwaegebaert Jwaegebaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add! Awesome work @MathijsVerbeeck!

@MathijsVerbeeck MathijsVerbeeck deleted the spo-listitem-attachment-set branch May 25, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: spo listitem attachment set
3 participants