Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhances spo theme list #5346

Closed
wants to merge 24 commits into from
Closed

Enhances spo theme list #5346

wants to merge 24 commits into from

Conversation

MathijsVerbeeck
Copy link
Contributor

Closes #5231

@milanholemans milanholemans added the pr-major PR for the next major release label Jul 25, 2023
@milanholemans
Copy link
Contributor

Thank you, we'll try to review it ASAP!

@milanholemans milanholemans linked an issue Jul 25, 2023 that may be closed by this pull request
Update output of spo theme list #5231
Closed
@milanholemans
Copy link
Contributor

Hi, @MathijsVerbeeck thank you for contributing to the next major release. Since this is a breaking change, could you please extend our v7 upgrade guidance with this breaking change?

Much appreciated! 🙏

@milanholemans milanholemans marked this pull request as draft July 26, 2023 23:18
@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review July 27, 2023 09:15
@milanholemans milanholemans self-assigned this Jul 29, 2023
@milanholemans
Copy link
Contributor

@MathijsVerbeeck seems like something went wrong while resolving the merge conflicts. The only change in this PR is to update the upgrade guidance. Could you have a look at it please?

@milanholemans milanholemans marked this pull request as draft July 29, 2023 21:43
@MathijsVerbeeck
Copy link
Contributor Author

@MathijsVerbeeck seems like something went wrong while resolving the merge conflicts. The only change in this PR is to update the upgrade guidance. Could you have a look at it please?

I love rebasing 😄
Should be fixed!

@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review July 31, 2023 08:45
@Adam-it
Copy link
Contributor

Adam-it commented Aug 5, 2023

@MathijsVerbeeck unfortunately this one as well will need a rebase with the latest v7 before we proceed 🙏. Thanks 👍

@milanholemans milanholemans marked this pull request as draft August 5, 2023 10:56
@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review August 8, 2023 22:16
milanholemans
milanholemans requested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Let's make a few tiny adjustments before we merge it.

src/m365/spo/commands/theme/theme-list.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/theme/theme-list.spec.ts Outdated Show resolved Hide resolved
docs/docs/v7-upgrade-guidance.mdx Outdated Show resolved Hide resolved
docs/docs/v7-upgrade-guidance.mdx Outdated Show resolved Hide resolved
docs/docs/v7-upgrade-guidance.mdx Outdated Show resolved Hide resolved
@milanholemans milanholemans marked this pull request as draft August 9, 2023 22:36
@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review August 11, 2023 17:08
milanholemans and others added 16 commits August 12, 2023 19:42
@milanholemans @waldekmastykarz
Updates release notes
44d0c8b
@SmitaNachan @waldekmastykarz
Remove --deleted option. Closes pnp#4516
fc6612d
@nanddeepn @waldekmastykarz
Extends spo tenant commandset set. Closes pnp#4961
c4c31ed
@arjunumenon @waldekmastykarz
Updates release notes
8826fbb
@MathijsVerbeeck @waldekmastykarz
Update response of few 'flow' commands. Closes pnp#4444
ca5c4f8
@milanholemans @waldekmastykarz
Updates release notes and upgrade guidance
a34c2e8
@waldekmastykarz
Migrates CLI to esm. Closes pnp#4306
724fc8a
@Adam-it @waldekmastykarz
Updates release notes
f25b4eb
@Adam-it @waldekmastykarz
Fixes update package version script
4dea7c9
@Adam-it @waldekmastykarz
Fixes npm publish script
1c9fdc3
@Adam-it @waldekmastykarz
Updates release notes
decb2c0
@nanddeepn @waldekmastykarz
Updates 'spo tenant applicationcustomizer get' command. Closes pnp#4872
4393cd1
@Saurabh7019 @waldekmastykarz
Update default help mode to 'options'. Closes pnp#5182
19d28c9
@MathijsVerbeeck @waldekmastykarz
Removes deprecated options from 'spo retentionlabel ensure'. Closes p…
d7c35d3 
…np#4207
@milanholemans @waldekmastykarz
Updates 'teams meeting list' command response. Closes pnp#4782
eeb6bb0
@Adam-it @waldekmastykarz
Updates release notes and upgrade guidance
b7c2a8d
milanholemans
milanholemans approved these changes Aug 12, 2023
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add!

@milanholemans
Copy link
Contributor

Merged manually, thank you! 👏

@MathijsVerbeeck MathijsVerbeeck deleted the spo-theme-list branch May 25, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milanholemans milanholemans milanholemans approved these changes

Assignees

@milanholemans milanholemans

Labels
pr-major PR for the next major release pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update output of spo theme list
10 participants
@MathijsVerbeeck @milanholemans @Adam-it @waldekmastykarz @martinlingstuyl @nanddeepn @plamber @Saurabh7019 @SmitaNachan @arjunumenon