Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor codebase to async/await - util constants #5342

Closed
wants to merge 1 commit into from
Closed

Refactor codebase to async/await - util constants #5342

wants to merge 1 commit into from

Conversation

MathijsVerbeeck
Copy link
Contributor

Closes #5144

@milanholemans
Copy link
Contributor

Thank you @MathijsVerbeeck, we'll try to review it ASAP!

@Jwaegebaert Jwaegebaert self-assigned this Sep 3, 2023
Jwaegebaert
Jwaegebaert approved these changes Sep 3, 2023
View reviewed changes
Copy link
Contributor

@Jwaegebaert Jwaegebaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @MathijsVerbeeck! Nothing to add 👏

@Jwaegebaert Jwaegebaert closed this Sep 8, 2023
@MathijsVerbeeck MathijsVerbeeck deleted the refactor-util branch May 25, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jwaegebaert Jwaegebaert Jwaegebaert approved these changes

Assignees

@Jwaegebaert Jwaegebaert

Labels
pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor codebase to async/await - util constants
3 participants
@MathijsVerbeeck @milanholemans @Jwaegebaert