Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up linting #6348

Open
waldekmastykarz opened this issue Sep 15, 2024 · 1 comment · May be fixed by #6349
Open

Speed up linting #6348

waldekmastykarz opened this issue Sep 15, 2024 · 1 comment · May be fixed by #6349

Comments

@waldekmastykarz
Copy link
Member

Let's see if we can speed up linting. Right now, on my M2 MBAir linting takes ~50s, which significantly impacts our builds and running the full test setup.

I had a quick look and found out, that an easy win would be to use caching with --cache --cache-strategy content so that eslint only checks modified files. A quick test showed a significant drop from ~50s to ~1s when no files modified and ~6s with one modified file. What's also great is that we can add it to our CI pipe, significantly shortening our build times.

@waldekmastykarz waldekmastykarz self-assigned this Sep 15, 2024
waldekmastykarz added a commit to waldekmastykarz/cli-microsoft365 that referenced this issue Sep 15, 2024
@waldekmastykarz waldekmastykarz linked a pull request Sep 15, 2024 that will close this issue
@Adam-it
Copy link
Contributor

Adam-it commented Sep 15, 2024

Or we may just drop linting 🤷.
Sorry 🙏 I had to write it 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants