From 84006acf21a70a04cca9766281b38e2413e46464 Mon Sep 17 00:00:00 2001 From: Nico De Cleyre Date: Tue, 18 Jul 2023 13:06:02 +0200 Subject: [PATCH] fix --- src/utils/spo.spec.ts | 80 +++++++++++++++++++++---------------------- 1 file changed, 39 insertions(+), 41 deletions(-) diff --git a/src/utils/spo.spec.ts b/src/utils/spo.spec.ts index dbff799b8af..cd5bc4b8217 100644 --- a/src/utils/spo.spec.ts +++ b/src/utils/spo.spec.ts @@ -46,36 +46,32 @@ describe('utils/spo', () => { let log: string[]; let loggerLogSpy: sinon.SinonSpy; const contentTypeResponse = { - value: [ - { - Description: 'Create a new list item.', - DisplayFormTemplateName: 'ListForm', - DisplayFormUrl: '', - DocumentTemplate: '', - DocumentTemplateUrl: '', - EditFormTemplateName: 'ListForm', - EditFormUrl: '', - Group: 'PnP Content Types', - Hidden: - false, - Id: { - StringValue: '0x0100558D85B7216F6A489A499DB361E1AE2F' - }, - JSLink: '', - MobileDisplayFormUrl: '', - MobileEditFormUrl: '', - MobileNewFormUrl: '', - Name: 'PnP Alert', - NewFormTemplateName: 'ListForm', - NewFormUrl: '', - ReadOnly: false, - SchemaXml: - 'ListFormListFormListForm', - Scope: '/sites/portal', - Sealed: false, - StringId: '0x0100558D85B7216F6A489A499DB361E1AE2F' - } - ] + Description: 'Create a new list item.', + DisplayFormTemplateName: 'ListForm', + DisplayFormUrl: '', + DocumentTemplate: '', + DocumentTemplateUrl: '', + EditFormTemplateName: 'ListForm', + EditFormUrl: '', + Group: 'PnP Content Types', + Hidden: + false, + Id: { + StringValue: '0x0100558D85B7216F6A489A499DB361E1AE2F' + }, + JSLink: '', + MobileDisplayFormUrl: '', + MobileEditFormUrl: '', + MobileNewFormUrl: '', + Name: 'PnP Alert', + NewFormTemplateName: 'ListForm', + NewFormUrl: '', + ReadOnly: false, + SchemaXml: + 'ListFormListFormListForm', + Scope: '/sites/portal', + Sealed: false, + StringId: '0x0100558D85B7216F6A489A499DB361E1AE2F' }; before(() => { @@ -1097,8 +1093,9 @@ describe('utils/spo', () => { throw 'Invalid request'; }); - const actual = await spo.getContentTypeById('https://contoso.sharepoint.com/sites/portal', '0x010200973548ACFFDA0948BE80AF607C4E28F9'); - assert.strictEqual(actual, contentTypeResponse.value[0]); + + const actual = await spo.getContentTypeById('https://contoso.sharepoint.com/sites/portal', '0x010200973548ACFFDA0948BE80AF607C4E28F9', logger, true); + assert.strictEqual(actual, contentTypeResponse); }); it('gets information about a list content type by id and list title', async () => { @@ -1109,8 +1106,9 @@ describe('utils/spo', () => { throw 'Invalid request'; }); - const actual = await spo.getContentTypeByListTitleAndId('https://contoso.sharepoint.com/sites/portal', '0x010200973548ACFFDA0948BE80AF607C4E28F9', 'Events'); - assert.strictEqual(actual, contentTypeResponse.value[0]); + + const actual = await spo.getContentTypeByListTitleAndId('https://contoso.sharepoint.com/sites/portal', 'Events', '0x010200973548ACFFDA0948BE80AF607C4E28F9', logger, true); + assert.strictEqual(actual, contentTypeResponse); }); it(`retrieves roledefinition by name sucessfully`, async () => { @@ -1173,8 +1171,8 @@ describe('utils/spo', () => { throw 'Invalid request'; }); - const actual = await spo.getContentTypeByListIdAndId('https://contoso.sharepoint.com/sites/portal', '0x010200973548ACFFDA0948BE80AF607C4E28F9', '9153a1f5-22f7-49e8-a854-06bb4477c2a2'); - assert.strictEqual(actual, contentTypeResponse.value[0]); + const actual = await spo.getContentTypeByListIdAndId('https://contoso.sharepoint.com/sites/portal', '9153a1f5-22f7-49e8-a854-06bb4477c2a2', '0x010200973548ACFFDA0948BE80AF607C4E28F9', logger, true); + assert.strictEqual(actual, contentTypeResponse); }); it('gets information about a list content type by id and list url', async () => { @@ -1186,8 +1184,8 @@ describe('utils/spo', () => { throw 'Invalid request'; }); - const actual = await spo.getContentTypeByListUrlAndId('https://contoso.sharepoint.com/sites/portal', '0x010200973548ACFFDA0948BE80AF607C4E28F9', 'documents'); - assert.strictEqual(actual, contentTypeResponse.value[0]); + const actual = await spo.getContentTypeByListUrlAndId('https://contoso.sharepoint.com/sites/portal', 'documents', '0x010200973548ACFFDA0948BE80AF607C4E28F9', logger, true); + assert.strictEqual(actual, contentTypeResponse); }); it('correctly handles site content type not found by id', async () => { @@ -1218,7 +1216,7 @@ describe('utils/spo', () => { }); try { - await spo.getContentTypeByListTitleAndId('https://contoso.sharepoint.com/sites/portal', '0x010200973548ACFFDA0948BE80AF607C4E28F9', 'Events'); + await spo.getContentTypeByListTitleAndId('https://contoso.sharepoint.com/sites/portal', 'Events', '0x010200973548ACFFDA0948BE80AF607C4E28F9'); assert.fail('No error message thrown.'); } catch (ex) { @@ -1236,7 +1234,7 @@ describe('utils/spo', () => { }); try { - await spo.getContentTypeByListIdAndId('https://contoso.sharepoint.com/sites/portal', '0x010200973548ACFFDA0948BE80AF607C4E28F9', '9153a1f5-22f7-49e8-a854-06bb4477c2a2'); + await spo.getContentTypeByListIdAndId('https://contoso.sharepoint.com/sites/portal', '9153a1f5-22f7-49e8-a854-06bb4477c2a2', '0x010200973548ACFFDA0948BE80AF607C4E28F9'); assert.fail('No error message thrown.'); } catch (ex) { @@ -1254,7 +1252,7 @@ describe('utils/spo', () => { }); try { - await spo.getContentTypeByListUrlAndId('https://contoso.sharepoint.com/sites/portal', '0x010200973548ACFFDA0948BE80AF607C4E28F9', 'documents'); + await spo.getContentTypeByListUrlAndId('https://contoso.sharepoint.com/sites/portal', 'documents', '0x010200973548ACFFDA0948BE80AF607C4E28F9'); assert.fail('No error message thrown.'); } catch (ex) {