There is a defect in the ref in proxyWithHistory

[18613109040]

An error was reported when a ref property was recovered using the proxyWithHistory component

Please include a minimal reproduction.
For details, go to add -> undo -> redo

• I've added a link to a codesandbox with a minimal reproduction.

[18613109040]

deepClone in proxyWithHistory wants keywords for ref not to be converted to a proxy structure

const deepClone = <T>(obj: T): T => {
  if (!isObject(obj)) {
    return obj
  }
  const baseObject: T = Array.isArray(obj)
    ? []
    : Object.create(Object.getPrototypeOf(obj))
  Reflect.ownKeys(obj).forEach((key) => {
  if (key === 'ref') {
        baseObject[key as keyof T] = Reflect.get(obj, key);
      } else {
        baseObject[key as keyof T] = deepClone(obj[key as keyof T]);
      }
  })
  return baseObject
}

[18613109040]

proxyWithHistory(appPages, { ignoreAttribute: "ref"}) Ignore attribute

[dai-shi]

Yeah, we found proxyWithHistory doesn't cover all cases.
Please feel free to investigate it.
You may want to create a new package if you have completely a new idea of the implementation.

[18613109040]

When will the new package be available?

[dai-shi]

Sorry for the confusion. I modified "We" -> "You".

[dai-shi]

An error was reported when a ref property was recovered using the proxyWithHistory component

For details, go to add -> undo -> redo

Not sure I get it. Can you reproduce it with very simple setup? Creating a repro with https://codesandbox.io/s/react-new would be good.

[18613109040]

https://codesandbox.io/s/old-shadow-v4sysy?file=/src/App.js

[dai-shi]

Thanks. I get your point. It's about valtio ref.
We need ref-aware deepClone.

For now, here's the userland solution: https://codesandbox.io/s/smoosh-frost-7pd201?file=/src/App.js

[dai-shi]

#727