Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compiled translations #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ziafazal
Copy link
Collaborator

This PR has compiled translations.
@pmitros Could you please merge and create a new release(1.2)?

added spanish compiled translation
@pmitros
Copy link
Owner

pmitros commented Jan 17, 2017

@ziafazal @e0d Can you please clarify as to the reason for including compiled files in the repo? That seems odd... Shouldn't these be built as part of the build/install process?

If not, I would still be hesitant to merge the outputs of a black box build process. There ought to be a Makefile, script, or similar (some way to rebuild them for new persons to the repo, unfamiliar with edX' i18n pipeline).

@ziafazal
Copy link
Collaborator Author

@pmitros Xblocks have to provide compiled versions of translations for themselves since current build process does not generate/compile translations for XBlocks.

XBlock developer can run this gettext command in base directory of XBlock to compile translations

$ msgfmt translations/{locale}/LC_MESSAGES/text.po -o translations/{locale}/LC_MESSAGES/text.mo 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants