Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posting comment without name breaks page for admin #110

Open
mck9 opened this issue Aug 16, 2016 · 6 comments
Open

Posting comment without name breaks page for admin #110

mck9 opened this issue Aug 16, 2016 · 6 comments

Comments

@mck9
Copy link

mck9 commented Aug 16, 2016

When posting a comment without a name as anonymous, admin is no longer able to open the page:

AttributeError("'TTWViewletRenderer' object has no attribute 'name'",) (Also, the following error occurred while attempting to render the standard error message, please see the event log for full details: 'TTWViewletRenderer' object has no attribute 'name')

plone.app.discussion 2.2.18 on Plone 4.3.10

@mck9 mck9 closed this as completed Aug 16, 2016
@mck9
Copy link
Author

mck9 commented Aug 16, 2016

This happens by customizing "plone.comments (plone.app.discussion.interfaces.IDiscussionLayer)" in portal_view_customizations

@mck9 mck9 reopened this Aug 16, 2016
@davilima6
Copy link
Member

davilima6 commented Aug 16, 2016

@mck9 portal_view_customizations is mostly broken and I suggested it should be deprecated. Also see: plone/Products.CMFPlone#1702 and plone/Products.CMFPlone#1632.

If this is indeed related to those kind of bugs, you could try collective.jbot to achieve similar results (i.e. customize a template through the web).

I couldn't reproduce it in http://plone-demo.quintagroup.com/ (can you?) but that wasn't with admin user but a site level ploneadmin. Does this happen only with admin from application root level?

@mck9
Copy link
Author

mck9 commented Aug 16, 2016

@davilima6 You can view the error here: http://plone-demo.quintagroup.com/news/site-upgrage (after login as ploneadmin)

@davilima6
Copy link
Member

davilima6 commented Aug 16, 2016

@mck9, thank you. It doesn't seem related to portal_view_customizations, though, since I deleted everything there and the bug persisted.

IINM it actually only happens when Enable comment moderation is enabled so I guess the bug lives in its viewlet. Also worth noting that even if you disable that option, a once broken page doesn't get fixed.

@mck9
Copy link
Author

mck9 commented Aug 16, 2016

@davilima6 this is strange, I fixed it by deleting the customization (locally). I also see, that plone.comments is marked as "customized", but the customization is missing (as you said).

How the viewlet and customized plone views relate is beyond my knowledge.

@davilima6
Copy link
Member

It's stange indeed that the item is still highlighted as customized after deletion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants