Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex for coverage doesn't match in .gitlab-ci #222

Open
1letter opened this issue May 1, 2024 · 3 comments
Open

Regex for coverage doesn't match in .gitlab-ci #222

1letter opened this issue May 1, 2024 · 3 comments

Comments

@1letter
Copy link

1letter commented May 1, 2024

The regex doesn't match for the coverage report in my gitlab instance, if disable the markdown option then all work as expected

@gforcada
Copy link
Member

gforcada commented May 1, 2024

Weird... it works for me ™️ we have a few customizations on .meta.toml but none that changes the tox coverage environment 🤔

My output in gitlab looks like this:

|   **TOTAL** | **5599** |  **123** |  **794** |   **61** | **97%** |           |

So the regex /TOTAL.* \*\*(\d+)\%\*\*/ does match the 97%.

How does your output look like? 🤔

Which version of coverage do you have installed? The output above is from coverage==7.4.0

@1letter
Copy link
Author

1letter commented May 1, 2024

@gforcada
Sorry it was my mistake, i have an old regex in my gitlab-ci file, copy&paste error 😦.
But i found another bug. zope.testrunner is pinnend in Plone 6.0 and Plone 6.1 constraints file to v6.2.x, but the line
- tox -e test -- --xml reports is only supported by zope.testrunner >= v6.3 https://pypi.org/project/zope.testrunner/#section-3

Traceback from my gitlab instance:

zope-testrunner: error: unrecognized arguments: --xml
test: exit 2 (0.53 seconds) /builds/xxx> zope-testrunner --all --test-path=/builds/xxx/src -s my.addon --xml reports pid=770
  test: FAIL code 2 (172.31=setup[105.35]+cmd[66.43,0.53] seconds)
  evaluation failed :( (172.41 seconds)
Uploading artifacts for failed job
00:01
Uploading artifacts...
WARNING: reports/testreports/*.xml: no matching files. Ensure that the artifact path is relative to the working directory (/builds/xxx) 
ERROR: No files to upload                          
Cleaning up project directory and file based variables
00:01
ERROR: Job failed: exit code 1

@gforcada
Copy link
Member

gforcada commented May 9, 2024

Oh, indeed, I see that locally I have an override to it on my local versions.cfg, but we should update that upstream as well 👍🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants