Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional workflow-run-id parameter to SemenaticVersion step implementer #45

Open
4 tasks
itewk opened this issue Jun 30, 2021 · 0 comments
Open
4 tasks
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@itewk
Copy link
Contributor

itewk commented Jun 30, 2021

purpose

Currently if you re-run a workflow using the same git commit hash, and you are tagging your git using the generated SematnicVesion you will get an error tyring to push the same tag again. To solve this issue and have even better versioning we should have an additional optional paramter to the SemanticVersion StepImplmenter called workflow-run-id that can be passed in at runtime (via the CLI) by the worfklow runner with the unique id of the workflow run to add to the semantic version if provided

design

we need to figure out if we should include this as part of the pre-release section or the build seciton of the version.

todo

  • research if other projects include the workflow run id in their version, which section of the version do they include it in
  • update SemVersion step implementer to take new optional parameter
  • update jenkins-lib to pass in optional parameter
  • update tekton helm charts to pass in optional paramter (this will be a bit tricky i think, and not sure if tekton has a run identifer or not)
@itewk itewk added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant