Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce boilerplate in pipeline definition per invocation of the psr command #22

Open
dwinchell opened this issue Jan 13, 2021 · 4 comments
Labels
good first issue Good for newcomers

Comments

@dwinchell
Copy link
Contributor

No description provided.

@dwinchell dwinchell added the good first issue Good for newcomers label Jan 13, 2021
@itewk
Copy link
Contributor

itewk commented Jun 30, 2021

@dwinchell not sure what this is about, but im guessing something with the jenkins lib and tekton lib stuff?

@dwinchell
Copy link
Contributor Author

I want to factor this out somehow, which we do for every step. A client looked at the file and said "oh, so here's the intelligence, in all that Bash." Which is exactly the opposite of what we want people to think when the look at it.

if [ "${params.verbose}" == "true" ]; then set -x; else set +x; fi set -eu -o pipefail source ${HOME}/${WORKFLOW_WORKER_VENV_NAME}/bin/activate

@dwinchell
Copy link
Contributor Author

The newlines were removed from my last post but it's 4 lines repeated 10 times

@itewk
Copy link
Contributor

itewk commented Jun 30, 2021

i mean we could move those 4 lines to a separate groovy function, it didn't seem worth the overhead. if you want to factor that part out go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants