Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All roadmap items have completed green bar - despite not being complete? #302

Closed
momack2 opened this issue Feb 6, 2023 · 3 comments · Fixed by #306 or #307
Closed

All roadmap items have completed green bar - despite not being complete? #302

momack2 opened this issue Feb 6, 2023 · 3 comments · Fixed by #306 or #307
Assignees
@SgtPooki
Labels
bug Something isn't working effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete P0

Comments

@momack2
Copy link

momack2 commented Feb 6, 2023

image

I'm confused why all the items in this roadmap are showing as completed? AFAIK many of them have ETAs in the future, and the issue is still opened - so not sure how we're getting the data to think they should be complete...

IMHO - using the closing of the issue, or adding some "status: complete" tag would be good enough to see an issue is landed - but these shouldn't be....
@SgtPooki SgtPooki mentioned this issue Feb 8, 2023
Closed
@SgtPooki SgtPooki self-assigned this Feb 8, 2023
@SgtPooki SgtPooki added bug Something isn't working P0 effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete labels Feb 8, 2023
@SgtPooki
Copy link
Contributor

SgtPooki commented Feb 8, 2023

i'll be working on this one today

@SgtPooki SgtPooki mentioned this issue Feb 8, 2023
Merged
@SgtPooki SgtPooki linked a pull request Feb 8, 2023 that will close this issue
fix: issueData.state is set properly #306
Merged
@SgtPooki
Copy link
Contributor

SgtPooki commented Feb 8, 2023

PR is out with fix, check https://starmaps-git-302-all-roadmap-items-have-comp-2b96ff-ipfs-ignite.vercel.app/roadmap/github.com/protocol/engres/issues/5#simple

@SgtPooki SgtPooki reopened this Feb 8, 2023
@SgtPooki
Copy link
Contributor

SgtPooki commented Feb 8, 2023

Yiannis reports seeing empty progress bars where they should be showing some progress now:

https://filecoinproject.slack.com/archives/C0418TBQ9CH/p1675888144792229?thread_ts=1675886012.689499&cid=C0418TBQ9CH

@SgtPooki SgtPooki linked a pull request Feb 8, 2023 that will close this issue
feat: calculation of completion_rate on client side #307
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SgtPooki SgtPooki

Labels
bug Something isn't working effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete P0
Projects
None yet
Milestone
No milestone
2 participants
@momack2 @SgtPooki