Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require date entry in ISO 8601 standard (YYYY-MM-DD) #275

Open
2 of 4 tasks
juliaxbow opened this issue Jan 20, 2023 · 3 comments
Open
2 of 4 tasks

Require date entry in ISO 8601 standard (YYYY-MM-DD) #275

juliaxbow opened this issue Jan 20, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete enhancement New feature or request status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs topic/data-entry

Comments

@juliaxbow
Copy link
Collaborator

juliaxbow commented Jan 20, 2023 •
edited by SgtPooki
Loading

Dates not following this format should return an error message in the starmap error log. This should be communicated out first and roadmap maintainers given an opportunity to update their roadmaps if necessary

Tasks
Beta Give feedback
  2. Add deprecation error for non-fully-specified dates #311
    P1 effort/hours enhancement
    SgtPooki

Done criteria for this is:

Support for non-fully-specified dates is completely removed and unrecognized. Errors display in starmap.site when loading roadmap items that have improperly formatted ETAs.
@SgtPooki SgtPooki added documentation Improvements or additions to documentation enhancement New feature or request status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete labels Jan 23, 2023
@SgtPooki SgtPooki self-assigned this Feb 10, 2023
@SgtPooki SgtPooki linked a pull request Feb 11, 2023 that will close this issue
feat: add ETA format deprecation warnings #312
Merged
@SgtPooki SgtPooki removed a link to a pull request Feb 11, 2023
feat: add ETA format deprecation warnings #312
Merged
@SgtPooki SgtPooki removed their assignment Mar 13, 2023
@momack2
Copy link

momack2 commented May 15, 2023

We used to support "2023Q2" - do we need to update all issues that still use this format? cc @SgtPooki

@momack2
Copy link

momack2 commented May 15, 2023

I'm also seeing conflicting results - ex libp2p/go-libp2p#2034 seems like it does hit the ISO standard - but I see this error:
CleanShot 2023-05-15 at 20 49 17@2x
CleanShot 2023-05-15 at 20 49 52@2x

@SgtPooki
Copy link
Contributor

@momack2 yes we need to update all ETAs to support the full iso format. I believe this is a request you were pushing for.

I will look into that issue, might be a caching problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete enhancement New feature or request status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs topic/data-entry
Projects
Starmap
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@momack2 @SgtPooki @juliaxbow