Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update type for findOneAndUpdate options #721

Open
ejmartin504 opened this issue Jan 24, 2024 · 0 comments
Open

Update type for findOneAndUpdate options #721

ejmartin504 opened this issue Jan 24, 2024 · 0 comments

Comments

@ejmartin504
Copy link
Collaborator

ejmartin504 commented Jan 24, 2024 •
edited
Loading

Currently we use the mongodb type for FindOneAndUpdateOptions options for findOneAndUpdate (https://github.com/plexinc/papr/blob/main/src/model.ts#L818)

However, a developer looking up the docs for these options will see returnDocument defaults to "before", while it defaults to "after" in papr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ejmartin504