Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add popup button at the top of the feed to check for new posts #215

Open
plebeius-eth opened this issue Jan 31, 2024 · 7 comments
Open

add popup button at the top of the feed to check for new posts #215

plebeius-eth opened this issue Jan 31, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@plebeius-eth
Copy link
Member

plebeius-eth commented Jan 31, 2024

I think all clients should have some warning similar to twitter where it says [there are new posts, click here]
even if 4chan and old reddit dont have it, we need it imo
twitter and new reddit have it

I slept on it and figured out how to implement useFeed().subplebbitAddressesWithNewerPosts already pushed it
so I guess you can add on the todo list of seedit to implement the popup like on twitter
not really sure if the UX is going to be good, we need to play around with it I think, kind of like how we did the time filter

I think a good design for the update thing would be

<HasNewPostsButton reset={reset} subplebbitAddressesWithNewerPosts={subplebbitAddressesWithNewerPosts} />

the component is an always floating modal that renders nothing if subplebbitAddressesWithNewerPosts.length === 0

@plebeius-eth plebeius-eth self-assigned this Jan 31, 2024
@plebeius-eth plebeius-eth converted this from a draft issue Jan 31, 2024
@plebeius-eth plebeius-eth added the enhancement New feature or request label Jan 31, 2024
@plebeius-eth plebeius-eth moved this from Todo to In Progress in seedit Feb 16, 2024
@plebeius-eth plebeius-eth moved this from In Progress to Todo in seedit Feb 16, 2024
@plebeius-eth plebeius-eth moved this from Todo to In Progress in seedit Feb 22, 2024
@plebeius-eth plebeius-eth moved this from In Progress to Todo in seedit Feb 25, 2024
@plebeius-eth plebeius-eth moved this from Todo to In Progress in seedit Apr 29, 2024
@plebeius-eth
Copy link
Member Author

0077df0

@github-project-automation github-project-automation bot moved this from In Progress to Done in seedit Jun 1, 2024
@estebanabaroa
Copy link
Member

estebanabaroa commented Jun 1, 2024

you should rename NewPosts with NewerPosts everywhere.

NewPosts is not accurate, it will only trigger if there are newer posts than the ones displayed. It won't trigger if there are new posts that are older than the ones displayed in the loaded feed.

I had originally said to have a component but that was a mistake, the correct name should be

@estebanabaroa estebanabaroa reopened this Jun 1, 2024
@estebanabaroa estebanabaroa moved this from Done to Todo in seedit Jun 1, 2024
@plebeius-eth plebeius-eth removed the status in seedit Jun 1, 2024
@plebeius-eth
Copy link
Member Author

fixed eb91de7

@estebanabaroa
Copy link
Member

design looks bad I think, I dont like the X, the green color or the font. I guess it should look more like one of the native reddit button. maybe just

image

also the button isn't centered properly in the feed, and has weird behavior when it scrolls. why not just use floating-ui like the ChallengesModal component.

by the way the UI can say "new posts", just the variable names should say "newer" posts because it's more technically accurate. but the UI probably looks weird with "newer"

@estebanabaroa estebanabaroa reopened this Jun 9, 2024
@estebanabaroa estebanabaroa moved this from Done to Todo in seedit Jun 9, 2024
@plebeius-eth plebeius-eth removed the status in seedit Jun 10, 2024
@plebeius-eth
Copy link
Member Author

replied on tg https://t.me/seeditreact/6762

8952f42

@estebanabaroa
Copy link
Member

estebanabaroa commented Sep 10, 2024

Screenshot from 2024-09-10 18-27-22

that looks awful, it's not centered, it looks randomly placed. also even if it were centered, the design looks terrible, it doesn't look like it's floating, it merges with the background and you can't see it well. also the [x] is a different size, so it looks out of place.

also the scrolling is laggy and not smooth, it's really awful in every aspect.

imo we should remove this altogether from production until we can make it looks good, and not sure we we can make it look good at the moment.

I guess it should probably be integrated into the grey top bar or the blue account bar, maybe we remove or push some item to the right in the top bar when there are new posts. I cannot imagine a way to make it look good as some floating button.

maybe we could place it where the get new reddit button is with a similar design? and when the user scrolls up, it merges with the grey bar, and when the user clicks X, it disappears?

image

If there's no good way to make it merge with the top bar on scroll up, then whenever there's newer posts, it would mean we would have to fix the top bar permanently until the user presses X on the newer posts button I guess.

This is pretty low priority and not sure it's that useful, and it will be hard to get right I think, might be better to abandon it for now

@estebanabaroa estebanabaroa reopened this Sep 10, 2024
@estebanabaroa estebanabaroa moved this from Done to Todo in seedit Sep 10, 2024
@estebanabaroa
Copy link
Member

estebanabaroa commented Sep 10, 2024

maybe something like this would be OK

image

the button could merge with the top bar when the user scrolls up

image

even then, it still looks kind of bad, we should probably just abandon it for now

@plebeius-eth plebeius-eth removed the status in seedit Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants