Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "seed" mode to the daemon #5

Open
Rinse12 opened this issue Apr 13, 2023 · 5 comments
Open

Add a "seed" mode to the daemon #5

Rinse12 opened this issue Apr 13, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Rinse12
Copy link
Member

Rinse12 commented Apr 13, 2023

The seed mode will support the demo subs through the following actions:

  • Fetch the subplebbits' IPNS regularly and seed it for the rest of IPFS network
  • Fetch the subplebbits' pages and comments and seed
  • It will also subscribe to their respective pubsub topic, which should make propagating challenges much faster
@Rinse12 Rinse12 self-assigned this Apr 13, 2023
@Rinse12 Rinse12 converted this from a draft issue Apr 13, 2023
@Rinse12 Rinse12 added the enhancement New feature or request label Apr 13, 2023
@estebanabaroa
Copy link
Member

estebanabaroa commented Apr 13, 2023

Seems fine to me. IMO the flag should be called --seed (open to suggestions for a better name) and should be considered experimental, I expect the functionality and name will change later.

I also think it should not be enabled by default. The average CLI user probably doesn't want to waste his bandwidth without his consent. He probably doesn't want things happening in the background without his consent.

The GUI is different, most users of the GUI will probably consume the default subs one way or another, so prefetching them in the background is positive.

Rinse12 added a commit that referenced this issue Apr 18, 2023
Rinse12 added a commit that referenced this issue Apr 18, 2023
@Rinse12
Copy link
Member Author

Rinse12 commented Apr 18, 2023

Should be implemented with version 0.7.0

@estebanabaroa
Copy link
Member

It seems the API is

plebbit daemon --seed --seedSubs mysub.eth, myothersub.eth, 12D3KooWEKA6Fhp6qtyttMvNKcNCtqH2N7ZKpPy5rfCeM1otr5qU`

wouldn't it be better do to:

For default subs:

plebbit daemon --seed

For specific subs

plebbit daemon --seed mysub.eth --seed 12D3KooWEKA6Fhp6qtyttMvNKcNCtqH2N7ZKpPy5rfCeM1otr5qU --seed myothersub.eth

ie if --seed is true, seed default subs, if --seed is string[], seed the list of strings

@estebanabaroa estebanabaroa reopened this Apr 18, 2023
@Rinse12
Copy link
Member Author

Rinse12 commented Apr 19, 2023

There doesn't seem to be a way for oclif to have more than one type for a flag, as far as I know.

I created a feature request for it:
oclif/core#690

@estebanabaroa
Copy link
Member

There doesn't seem to be a way for oclif to have more than one type for a flag, as far as I know.

I created a feature request for it: oclif/core#690

imo it should be plebbit daemon --seed <address> --seed <address> --seed <address> not plebbit daemon --seed <address> <address> <address> because it's difficult to know that the

are part of the --seed flag and not part of the daemon command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants