Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow translation callbacks of S7ItemGroup to be async #112

Open
gfcittolin opened this issue May 8, 2020 · 0 comments
Open

Allow translation callbacks of S7ItemGroup to be async #112

gfcittolin opened this issue May 8, 2020 · 0 comments
Assignees
@gfcittolin
Labels
enhancement
Milestone
v1.0

Comments

@gfcittolin
Copy link
Collaborator

The function passed to S7ItemGroup.setTranslationCB() is currently expected to be sync. This prevents us to query its value from an async source (like a database).

We could add support to promise-based translation functions, that would then handle both sync and async cases
@gfcittolin gfcittolin added this to the v1.0 milestone May 8, 2020
@gfcittolin gfcittolin self-assigned this May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gfcittolin gfcittolin

Labels
enhancement
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
1 participant
@gfcittolin