Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add problem library #2

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Add problem library #2

wants to merge 16 commits into from

Conversation

pixlcrashr
Copy link
Member

The problems library implements the RFC 7807 standard in Go.

The goal of this implementation is the unification of microservice errors thrown in (often) HTTP microservices.

@kwiesmueller kwiesmueller self-requested a review November 9, 2018 21:51
@kwiesmueller kwiesmueller self-assigned this Nov 9, 2018
README.md Show resolved Hide resolved
problems/problems.go Outdated Show resolved Hide resolved
problems/problems.go Outdated Show resolved Hide resolved
problems/problems.go Outdated Show resolved Hide resolved
problems/problems.go Outdated Show resolved Hide resolved
problems/problems.go Outdated Show resolved Hide resolved
Copy link
Member

@kwiesmueller kwiesmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I would like to make a comparable UX as github.com/pkg/errors does.

While I am not really familiar with the RFC Spec yet, I would hope to get a way of working hand in hand with errors.
So providing Wrap functions and ways to transition from common errors to a user facing RFC compliant error.

problems/problems.go Outdated Show resolved Hide resolved
problems/problems.go Outdated Show resolved Hide resolved
problems/problems.go Outdated Show resolved Hide resolved
Copy link
Member

@kwiesmueller kwiesmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and I know it's really primitive code, but at least some test coverage would be great to have. Information function covering as much as possible would be great already.
An example would do as well.

And could somebody please explain why Github on mobile keeps jumping to the top whenever I submitted a damn comment!? :#

problems/problems.go Outdated Show resolved Hide resolved
problems/problems.go Outdated Show resolved Hide resolved
kwiesmueller added a commit that referenced this pull request Mar 21, 2019
@pixlcrashr pixlcrashr changed the title Add problems library Add problem library Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants