Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.20.5 #3424

Merged
merged 4 commits into from
Apr 20, 2024
Merged

Update to 1.20.5 #3424

merged 4 commits into from
Apr 20, 2024

Conversation

DrexHD
Copy link
Contributor

@DrexHD DrexHD commented Jan 23, 2024

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure your name is added to Contributors file /Plan/common/src/main/java/com/djrapitops/plan/delivery/rendering/html/Contributors.java
  • If PR:ing locale changes also add a LangCode with your name /Plan/common/src/main/java/com/djrapitops/plan/settings/locale/LangCode.java

Description

This draft PR is intended to track the progress of updating this mod (fabric module) to 1.20.5

Thank you!

@AuroraLS3
Copy link
Collaborator

Awesome!

@DrexHD
Copy link
Contributor Author

DrexHD commented Apr 19, 2024

This has now been ported to 1.20.5-rc2 and is ready for review. No further changes are expected for 1.20.5!

1.20.5 bumped the Java version used by Minecraft from 17 to 21, this PR reflects that change. This doesn't seem to cause any problems in the project.

@DrexHD DrexHD marked this pull request as ready for review April 19, 2024 23:31
Copy link
Collaborator

@AuroraLS3 AuroraLS3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you change jitpack.yml to install JDK 21, I think it's using 20 atm

@AuroraLS3
Copy link
Collaborator

I'll merge this since it fixes a build issue with 0.3-SNAPSHOT of fabric permissions api

@AuroraLS3 AuroraLS3 merged commit faa911e into plan-player-analytics:master Apr 20, 2024
1 check passed
SerpentesNL added a commit to SerpentesNL/Plan that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants