Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance submission schema with review assignment data #9965

Closed
3 tasks done
Vitaliy-1 opened this issue May 17, 2024 · 6 comments
Closed
3 tasks done

Enhance submission schema with review assignment data #9965

Vitaliy-1 opened this issue May 17, 2024 · 6 comments
Assignees
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Milestone

Comments

@Vitaliy-1
Copy link
Collaborator

Vitaliy-1 commented May 17, 2024

  • Reviewer name
  • Review method
  • Anonymize review assignment data for blind reviews
@Vitaliy-1 Vitaliy-1 added the Accessibility Any issue that impacts assistive technology or users with visual or physical impairments. label May 17, 2024
@Vitaliy-1 Vitaliy-1 added this to the 3.5 Internal milestone May 17, 2024
@Vitaliy-1 Vitaliy-1 added Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. and removed Accessibility Any issue that impacts assistive technology or users with visual or physical impairments. labels May 17, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue May 24, 2024
Vitaliy-1 added a commit to Vitaliy-1/ojs that referenced this issue May 24, 2024
@Vitaliy-1
Copy link
Collaborator Author

Vitaliy-1 commented May 24, 2024

PRs
pkp-lib: #9984
OJS: pkp/ojs#4289
OMP: pkp/omp#1587
OPS: pkp/ops#702

Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue May 27, 2024
Vitaliy-1 added a commit to Vitaliy-1/ojs that referenced this issue May 27, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue May 27, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue May 30, 2024
Vitaliy-1 added a commit to Vitaliy-1/ojs that referenced this issue May 30, 2024
@Vitaliy-1
Copy link
Collaborator Author

@bozana, can you take a look at these PRs? This solves the problem of showing additional review data on the new submissions list. I've added it to the submission schema, so it's available also from submission API endpoint for authors and reviewers, which means that sensitive data should be anonymized if review isn't open.

@bozana
Copy link
Collaborator

bozana commented Jun 3, 2024

Hi @Vitaliy-1, the PRs look good to me! Please, go ahead...

Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Jun 4, 2024
Vitaliy-1 added a commit to Vitaliy-1/ojs that referenced this issue Jun 4, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Jun 5, 2024
Vitaliy-1 added a commit to Vitaliy-1/ojs that referenced this issue Jun 5, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Jun 5, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Jun 11, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Jun 11, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Jun 11, 2024
@Vitaliy-1
Copy link
Collaborator Author

@jardakotesovec, I've updated the PR according to our discussion regarding the _submissions/assigned endpoint for authors, can you take a look?

@jardakotesovec
Copy link
Contributor

@Vitaliy-1 Here is idea.. likely naive as I am still trying to grasp how the permissions/access are handled, but here we go..

We already have challenge on multiple API endpoints - where if user has multiple roles (reviewer/author/editor), we might return more data than we want - like incorrect dashboard views, or incorrect result to particular dashboard view.

So how about if we introduce more general concept where I can set in the API (probably via query param) that I want to reduce the roles - some top layer would reduce the roles I am accessing the system with and than the API would have easier time to reason about things, if they for example think I am just author - it won't lead any additional data, just because I happen to also be editor.

With that - would not be possible to have just simple implementation for review assignment on the submissions schema, where it would anonymise them based on 'having just author role and review assignment is not open'?

@jardakotesovec
Copy link
Contributor

jardakotesovec commented Jun 11, 2024

Hmm.. this probably would not work.. Because I guess that some editor roles can't access all submissions unless they are assigned to them, right?

So when API would be used directly - than theoretically editor who is also author could access more than he should with the approach suggested above.

Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Jun 11, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Jun 12, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Jun 12, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Jun 12, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Jun 12, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Jun 12, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Jun 12, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Jun 12, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Jun 12, 2024
Vitaliy-1 added a commit to Vitaliy-1/ojs that referenced this issue Jun 12, 2024
Vitaliy-1 added a commit that referenced this issue Jun 12, 2024
#9965 Add reviewer name and review method into submission schema
Vitaliy-1 added a commit to pkp/ojs that referenced this issue Jun 12, 2024
Vitaliy-1 added a commit to Vitaliy-1/omp that referenced this issue Jun 12, 2024
Vitaliy-1 added a commit to pkp/omp that referenced this issue Jun 12, 2024
Vitaliy-1 added a commit to Vitaliy-1/ops that referenced this issue Jun 12, 2024
Vitaliy-1 added a commit to pkp/ops that referenced this issue Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
None yet
Development

No branches or pull requests

4 participants