-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not remove numbers from the beginning of each citation #9946
Labels
Enhancement:1:Minor
A new feature or improvement that can be implemented in less than 3 days.
Milestone
Comments
bozana
added
Bug:1:Low
A bug that does not have a severe consequence or affects a small number of users.
Enhancement:1:Minor
A new feature or improvement that can be implemented in less than 3 days.
and removed
Bug:1:Low
A bug that does not have a severe consequence or affects a small number of users.
labels
May 8, 2024
GaziYucel
added a commit
to GaziYucel/pkp-lib
that referenced
this issue
May 22, 2024
bozana
added a commit
to bozana/ojs
that referenced
this issue
May 24, 2024
bozana
added a commit
to bozana/omp
that referenced
this issue
May 24, 2024
bozana
added a commit
to bozana/ops
that referenced
this issue
May 24, 2024
This was referenced May 24, 2024
bozana
pushed a commit
to bozana/pkp-lib
that referenced
this issue
May 27, 2024
bozana
added a commit
to bozana/ojs
that referenced
this issue
May 27, 2024
bozana
added a commit
to bozana/omp
that referenced
this issue
May 27, 2024
bozana
added a commit
to bozana/ops
that referenced
this issue
May 27, 2024
Hi @jonasraoni, could you please take a look at the PR above? |
Thanks for reminding me! I'll take a look :) |
bozana
pushed a commit
to bozana/pkp-lib
that referenced
this issue
May 31, 2024
bozana
added a commit
to bozana/ojs
that referenced
this issue
May 31, 2024
bozana
added a commit
to bozana/omp
that referenced
this issue
May 31, 2024
bozana
added a commit
to bozana/ops
that referenced
this issue
May 31, 2024
bozana
added a commit
to bozana/pkp-lib
that referenced
this issue
May 31, 2024
bozana
added a commit
to bozana/ojs
that referenced
this issue
May 31, 2024
bozana
added a commit
to bozana/omp
that referenced
this issue
May 31, 2024
bozana
added a commit
to bozana/ojs
that referenced
this issue
May 31, 2024
bozana
added a commit
to bozana/ops
that referenced
this issue
May 31, 2024
This was referenced May 31, 2024
bozana
added a commit
to bozana/pkp-lib
that referenced
this issue
May 31, 2024
bozana
added a commit
to bozana/ojs
that referenced
this issue
May 31, 2024
bozana
added a commit
to bozana/omp
that referenced
this issue
May 31, 2024
bozana
added a commit
to bozana/ops
that referenced
this issue
May 31, 2024
This was referenced May 31, 2024
bozana
added a commit
that referenced
this issue
May 31, 2024
#9946 Do not remove numbers from the beginning of each cit…
bozana
added a commit
to pkp/ojs
that referenced
this issue
May 31, 2024
pkp/pkp-lib#9946 submodule update ##bozana/9946##
bozana
added a commit
to pkp/omp
that referenced
this issue
May 31, 2024
pkp/pkp-lib#9946 submodule update ##bozana/9946##
bozana
added a commit
to pkp/ops
that referenced
this issue
May 31, 2024
pkp/pkp-lib#9946 submodule update ##bozana/9946##
bozana
added a commit
to pkp/ojs
that referenced
this issue
May 31, 2024
pkp/pkp-lib#9946 submodule udpate ##bozana/9946-3_3_0##
bozana
added a commit
to pkp/omp
that referenced
this issue
May 31, 2024
pkp/pkp-lib#9946 submodule udpate ##bozana/9946-3_3_0##
bozana
added a commit
to pkp/ops
that referenced
this issue
May 31, 2024
pkp/pkp-lib#9946 submodule udpate ##bozana/9946-3_3_0##
bozana
added a commit
that referenced
this issue
Jun 1, 2024
#9946 Do not remove numbers from the beginning of each cit…
bozana
added a commit
to pkp/ojs
that referenced
this issue
Jun 1, 2024
pkp/pkp-lib#9946 submodule udpate ##bozana/9946-3_4_0##
bozana
added a commit
to pkp/omp
that referenced
this issue
Jun 1, 2024
pkp/pkp-lib#9946 submodule udpate ##bozana/9946-3_4_0##
bozana
added a commit
to pkp/ops
that referenced
this issue
Jun 1, 2024
pkp/pkp-lib#9946 submodule udpate ##bozana/9946-3_4_0##
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement:1:Minor
A new feature or improvement that can be implemented in less than 3 days.
Remove this part of the code https://github.com/pkp/pkp-lib/blob/stable-3_4_0/classes/citation/CitationListTokenizerFilter.php#L59-L62, that removes numbers from the beginning of each citation.
S. https://forum.pkp.sfu.ca/t/if-a-reference-list-item-starts-with-a-numeral-it-is-removed-3-1-2-4-and-3-3-0-15/87845.
This way the correct citations that start with a number will be correctly reprocessed and displayed. For the others, that this part of the code tries to solve: actually the editor is responsible for entering the correct citations and not for example a numbered list.
PRs:
stable-3_3_0:
stable-3_4_0:
main:
The text was updated successfully, but these errors were encountered: