Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify PlexPartialObject eq return #1230

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Simplify PlexPartialObject eq return #1230

merged 1 commit into from
Aug 27, 2023

Conversation

JonnyWong16
Copy link
Collaborator

Description

Don't need to check for None or [] with the instance check for PlexPartialObject.

See #1182 (comment)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 merged commit 0399bea into pkkid:master Aug 27, 2023
3 checks passed
@glensc glensc mentioned this pull request Aug 30, 2023
Merged
6 tasks
@JonnyWong16 JonnyWong16 deleted the bugfix/PlexPartialObject_eq branch September 18, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
non-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JonnyWong16