Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alert): add option to use custom socket #1219

Conversation

ReenigneArcher
Copy link
Contributor

@ReenigneArcher ReenigneArcher commented Aug 19, 2023

Description

This PR adds the ability to pass in a custom socket for the AlertListener.

In some cases attempting to use the AlertListener, will fail with the message getsockaddrarg: bad family. I believe this is due to using IPv6 on Linux hosts, but I cannot confirm. Adding the ability to use a custom socket, would allow the developer to create their own socket to use in this event.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@ReenigneArcher ReenigneArcher force-pushed the feat(alert)-add-option-to-use-custom-socket branch from 9e951f6 to 5245db8 Compare August 19, 2023 17:34
plexapi/alert.py Outdated Show resolved Hide resolved
@ReenigneArcher ReenigneArcher force-pushed the feat(alert)-add-option-to-use-custom-socket branch from 5245db8 to 661da0a Compare August 27, 2023 23:24
requirements.txt Outdated Show resolved Hide resolved
@ReenigneArcher ReenigneArcher force-pushed the feat(alert)-add-option-to-use-custom-socket branch from 661da0a to b15d12c Compare August 28, 2023 02:11
@JonnyWong16 JonnyWong16 merged commit 103bc6f into pkkid:master Aug 28, 2023
3 checks passed
@ReenigneArcher ReenigneArcher deleted the feat(alert)-add-option-to-use-custom-socket branch August 28, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants