Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash when making call if call setting is not supplied #4074

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

sauwming
Copy link
Member

To fix #4073, due to the change in #4052.

Call setting is optional, so if not supplied it will cause a crash.

@nanangizz
Copy link
Member

Just an idea, to avoid same problem in the future, perhaps set opt = &call->opt if opt is NULL, after apply_call_setting()?

@sauwming sauwming merged commit 9543a1b into master Sep 17, 2024
36 checks passed
@sauwming sauwming deleted the opt-call-id-check branch September 17, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when placing call
3 participants