Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Opus decoder PLC setting #4015

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fixed Opus decoder PLC setting #4015

merged 1 commit into from
Jul 12, 2024

Conversation

sauwming
Copy link
Member

According to RFC 7587:

The "useinbandfec" parameter is a unidirectional receive-only
      parameter.
useinbandfec:  specifies that the decoder has the capability to take
      advantage of the Opus in-band FEC.

So if remote FMTP signals that it doesn't wish to use FEC, it should have no impact to our local/decoding PLC setting, attr->setting.plc, which will be used by stream to decide whether to recover a frame.

@sauwming sauwming self-assigned this Jul 11, 2024
@sauwming sauwming added this to the release-2.15 milestone Jul 11, 2024
@sauwming sauwming merged commit 9b10599 into master Jul 12, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanangizz nanangizz nanangizz approved these changes

@trengginas trengginas Awaiting requested review from trengginas

Assignees

@sauwming sauwming

Labels
component: pjmedia type: bug
Projects
None yet
Milestone
release-2.15
Development

Successfully merging this pull request may close these issues.
2 participants
@sauwming @nanangizz