Make sure pj_dns_resolver_start_query() returns NULL for query object when returning from cache #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rned from the cache
sauwming
approved these changes
Jun 20, 2024
nanangizz
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3990 I updated the description of pj_dns_resolver_start_query() saying that if a pointer for a query object is specified then NULL will be returned if the answer is available from cache.
However, this is not happening because I didn't notice the function returns early when a cached response is available.
This PR corrects this behaviour and sets the pointer to NULL before calling the user callback and then returning from the function.