Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RTP packet lost when seq == 0 #3655

Closed
joeduff opened this issue Aug 9, 2023 · 1 comment · Fixed by #3653
Closed

Fixed RTP packet lost when seq == 0 #3655

joeduff opened this issue Aug 9, 2023 · 1 comment · Fixed by #3653

Comments

@joeduff
Copy link

joeduff commented Aug 9, 2023

Describe the bug

file : pjmedia\src\pjmedia\rtp.c
function : pjmedia_rtp_seq_update
bug : if (seq == sess->max_seq+ 1)
modify : if (seq == (pj_uint16_t)(sess->max_seq+ 1))
describe :
seq = 0
==> sess->max_seq = 65535
if (seq == sess->max_seq+ 1)
==> if (0 == 65536)
if (seq == (pj_uint16_t)(sess->max_seq+ 1))
==> if (0 == 0)

Steps to reproduce

seq = 0

PJSIP version

master

Context

The issue happens on Windows linphone Desktop 5.0.18 - Qt5.15.2 Core 5.2.75

Log, call stack, etc

none
@sauwming sauwming linked a pull request Aug 11, 2023 that will close this issue
@sauwming
Copy link
Member

Thanks for the suggestion. Since we're working on a related issue, I include the fix into #3653.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants