Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification display #2895

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Fix notification display #2895

merged 2 commits into from
Mar 7, 2022

Conversation

fregante
Copy link
Contributor

@fregante fregante commented Mar 7, 2022

I made a mistake in a commit before merging #2836, the colon and space was not added + the error was appended even if it was not an error at all.

Screen Shot 10

@fregante fregante added bug Something isn't working priority labels Mar 7, 2022
@fregante fregante requested a review from twschiller March 7, 2022 11:31
@fregante
Copy link
Contributor Author

fregante commented Mar 7, 2022

Might as well also fix this button’s size, there's a mismatch because it was being developed while I was turning Panel.scss into a CSSmodule

Before, big

Screen Shot 18

After, same size as others

Screen Shot 20

@twschiller twschiller added this to the 1.5.6 milestone Mar 7, 2022
@twschiller twschiller merged commit c59c8af into main Mar 7, 2022
@twschiller twschiller deleted the F/bug/notification-errors branch March 7, 2022 15:06
twschiller pushed a commit that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants