Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save button doesn't open the save modal sometimes #9266

Open
fungairino opened this issue Oct 10, 2024 · 1 comment
Open

Save button doesn't open the save modal sometimes #9266

fungairino opened this issue Oct 10, 2024 · 1 comment
Labels
bug Something isn't working user experience Improve the user experience (UX)

Comments

@fungairino
Copy link
Collaborator

fungairino commented Oct 10, 2024

Describe the bug

The save button re-mounts several times so we need to retry clicking the saveButton until the modal is visible in end to end tests.

For end users this means that sometimes clicking this button does nothing and they don't know why. This happens most often right after loading the page editor, but also just happens intermittently.

To Reproduce

Screen.Recording.2024-10-10.at.1.45.05.PM.mov

Expected behavior

The save button always works, or is disabled if it is not clickable yet.

Additional context

// The save button re-mounts several times so we need to retry clicking the saveButton until the modal is visible

@fungairino fungairino added the bug Something isn't working label Oct 10, 2024
@twschiller twschiller added the user experience Improve the user experience (UX) label Oct 29, 2024
@twschiller
Copy link
Contributor

Related code?:

message: "Mod definitions not loaded yet. Try again.",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user experience Improve the user experience (UX)
Projects
None yet
Development

No branches or pull requests

2 participants