Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tempdir usage in ffi-infer #459

Merged
merged 1 commit into from
Dec 7, 2015
Merged

Conversation

bendlas
Copy link
Contributor

@bendlas bendlas commented Dec 4, 2015

  • Make use of mkdtemp to create unique temporary directories per call to
    run-infer
  • If $TMPDIR is set, use it instead of /tmp
  • Remove temp files after finishing

see #455

- Make use of mkdtemp to create unique temporary directories per call to
  run-infer
- If $TMPDIR is set, use it instead of /tmp
- Remove temp files after finishing
@heyLu
Copy link
Member

heyLu commented Dec 4, 2015

The failure is the same as in #458, because something on the pypy side changed. (Not sure what, and I didn't have time yet to figure out what it might be.)

@bendlas
Copy link
Contributor Author

bendlas commented Dec 4, 2015

I suggest fixing the pypy version to the latest release: https://bitbucket.org/pypy/pypy/downloads/pypy-4.0.1-src.tar.bz2 That's what I did with the nix package.
We can still deal with the problem if it persists with the next release.

heyLu added a commit that referenced this pull request Dec 7, 2015
Improve tempdir usage in ffi-infer
@heyLu heyLu merged commit 1fc072b into pixie-lang:master Dec 7, 2015
@heyLu
Copy link
Member

heyLu commented Dec 7, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants