Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting branch #434

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thomasmulvaney
Copy link
Member

FIxes stackoverflow in JIT mode with a trampoline. We should still look for a C lib that could do this stuff or at least do a dirty mutating approach which is more JIT friendly. For now this is at least a simple solution.

@heyLu
Copy link
Member

heyLu commented Nov 7, 2015

Can you make the helper functions (trampoline and the -merge fns) private?

You also mentioned in #361 that you had implemented a version using arrays, do you still have that or did it not work out?

@thomasmulvaney
Copy link
Member Author

I agree the helpers should be private. Trampoline might be the exception as
it is rather useful. My mutating version got over ambitious when I tried
adding some of the TimSort optimizations - it's rather broken at the moment.

I'll make those adjusts tomorrow evening.

Cheers
On Nov 7, 2015 9:42 AM, "Lucas Stadler" [email protected] wrote:

Can you make the helper functions (trampoline and the -merge fns) private?

You also mentioned in #361 that you had implemented a version using
arrays, do you still have that or did it not work out?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants