*: try to fix download racing bugs

.github/workflows/integrate-dm.yaml

@@ -97,7 +97,7 @@ jobs:
       - name: Upload component log
         if: ${{ failure() }}
         # if: always()
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v3
         with:
           name: dm_logs
           path: ${{ env.working-directory }}/dm.logs.tar.gz

.github/workflows/integrate-playground.yaml

@@ -77,7 +77,7 @@ jobs:
       - name: Upload component log
         if: ${{ failure() }}
         # if: always()
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v3
         with:
           name: playground_logs
           path: ${{ env.working-directory }}/playground.logs.tar.gz

pkg/cluster/operation/download.go

@@ -51,7 +51,7 @@ func Download(component, nodeOS, arch string, version string) error {
 		if err := repo.DownloadComponent(component, version, targetPath); err != nil {
 			return err
 		}
-	} else {
+	} else if version != "nightly" {
 		if err := repo.VerifyComponent(component, version, targetPath); err != nil {
 			os.Remove(targetPath)
 		}

pkg/repository/v1_repository.go

@@ -483,12 +483,16 @@ func (r *V1Repository) updateComponentManifest(id string, withYanked bool) (*v1m
 // DownloadComponent downloads the component specified by item into local file,
 // the component will be removed if hash is not correct
 func (r *V1Repository) DownloadComponent(item *v1manifest.VersionItem, target string) error {
-	targetDir := filepath.Dir(target)
-	err := r.mirror.Download(item.URL, targetDir)
+	// make a tempdir such that every download will not inference each other
+	targetDir, err := os.MkdirTemp(filepath.Dir(target), "download")
 	if err != nil {
 		return err
 	}
 
+	if err := r.mirror.Download(item.URL, targetDir); err != nil {
+		return err
+	}
+
 	// the downloaded file is named by item.URL, which maybe differ to target name
 	if downloaded := path.Join(targetDir, item.URL); downloaded != target {
 		err := os.Rename(downloaded, target)