Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ansiterm #2403

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Remove ansiterm #2403

merged 6 commits into from
Apr 10, 2024

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested a review from breezewish April 10, 2024 13:11
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 10, 2024
@nexustar nexustar added this to the v1.16.0 milestone Apr 10, 2024
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 10, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-10 15:05:52.586112404 +0000 UTC m=+1061214.113652952: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

kaaaaaaang commented Apr 10, 2024 •
edited
Loading

/approve

@kaaaaaaang kaaaaaaang merged commit 28927f8 into pingcap:master Apr 10, 2024
18 of 19 checks passed
kaaaaaaang pushed a commit that referenced this pull request Apr 11, 2024
@nexustar @kaaaaaaang
Remove ansiterm (#2403)
d6cb82d 
* add tabdisplayer

* revert to cheynewallace/tabby

* use go-pretty to show table

* update border

* use nexustar/go-pretty
kaaaaaaang pushed a commit that referenced this pull request May 28, 2024
@nexustar @kaaaaaaang
Remove ansiterm (#2403)
4ff76f7 
* add tabdisplayer

* revert to cheynewallace/tabby

* use go-pretty to show table

* update border

* use nexustar/go-pretty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish Awaiting requested review from breezewish

Assignees
No one assigned
Labels
lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nexustar @kaaaaaaang