Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of mirror renw #2400

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Apr 5, 2024

What problem does this PR solve?

GetComponentManifest() can return a nil manifest if it returns an error. newMirrorRenewCmd() ignores expiration errors when calling GetComponentManifest(). It should make sure that the manifest is not nil when calling RenewManifest().

ref #2398

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

Bugfix: The `tiup mirror renew` command could segfault on expired manifests.

@ti-chi-bot ti-chi-bot bot requested review from breezewish and nexustar April 5, 2024 11:51
Copy link
Contributor

ti-chi-bot bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 55.93%. Comparing base (6f01692) to head (d11e769).

❗ Current head d11e769 differs from pull request most recent head 5ab50e4. Consider uploading reports for the commit 5ab50e4 to get more accurate results

Files Patch % Lines
cmd/mirror.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2400      +/-   ##
==========================================
- Coverage   55.95%   55.93%   -0.02%     
==========================================
  Files         329      329              
  Lines       35221    35224       +3     
==========================================
- Hits        19706    19702       -4     
- Misses      13143    13149       +6     
- Partials     2372     2373       +1     
Flag Coverage Δ
tiup 33.58% <0.00%> (-0.06%) ⬇️
unittest 22.15% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang kaaaaaaang added this to the v1.15.1 milestone Apr 9, 2024
@kaaaaaaang
Copy link
Collaborator

/lgtm

@kaaaaaaang kaaaaaaang merged commit 60c0cb3 into pingcap:master Apr 9, 2024
18 of 19 checks passed
@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-09 12:20:06.272743816 +0000 UTC m=+964867.800284360: ☑️ agreed by kaaaaaaang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants