Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: fix cannot deploy grafana and prometheus #2257

Merged
merged 2 commits into from
Aug 20, 2023

Conversation

nexustar
Copy link
Collaborator

…r DMMaster

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested a review from srstack August 18, 2023 16:21
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 18, 2023
@nexustar nexustar changed the title dm: fix cannot deploy grafana and prometheus when set source field fo… dm: fix cannot deploy grafana and prometheus Aug 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-20 17:41:53.865813942 +0000 UTC m=+1084878.414829925: ☑️ agreed by kaaaaaaang.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 20, 2023
@ti-chi-bot ti-chi-bot bot merged commit 2feb74b into pingcap:master Aug 20, 2023
16 checks passed
@kaaaaaaang kaaaaaaang added this to the 1.13.0 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants