Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go-sql-driver/mysql version to v1.7.1 #2246

Merged
merged 9 commits into from
Nov 9, 2023

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Aug 13, 2023

What problem does this PR solve?

close #2237

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested a review from breezewish August 13, 2023 13:36
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2eaf957) 55.39% compared to head (949e45b) 50.30%.

❗ Current head 949e45b differs from pull request most recent head e1aece8. Consider uploading reports for the commit e1aece8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2246      +/-   ##
==========================================
- Coverage   55.39%   50.30%   -5.08%     
==========================================
  Files         325      324       -1     
  Lines       34705    34694      -11     
==========================================
- Hits        19222    17452    -1770     
- Misses      13184    14955    +1771     
+ Partials     2299     2287      -12     
Flag Coverage Δ
cluster 44.84% <ø> (+0.15%) ⬆️
dm 25.48% <ø> (+<0.01%) ⬆️
playground 15.25% <ø> (-0.03%) ⬇️
tiup 15.56% <ø> (ø)
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 62 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dveeden
Copy link
Contributor

dveeden commented Aug 16, 2023

unit-test reports: "Files go.sum and /tmp/go.sum.before differ". Maybe you need to run a go mod tidy?

@srstack
Copy link
Collaborator Author

srstack commented Aug 16, 2023

unit-test reports: "Files go.sum and /tmp/go.sum.before differ". Maybe you need to run a go mod tidy?

tks~

@dveeden
Copy link
Contributor

dveeden commented Nov 8, 2023

/test unit-test

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2023

@dveeden: No presubmit jobs available for pingcap/tiup@master

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden
Copy link
Contributor

dveeden commented Nov 8, 2023

/retest

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2023

@dveeden: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden
Copy link
Contributor

dveeden commented Nov 8, 2023

Not sure why unit-test is still showing a failure. Running a go mod tidy locally gives a clean result.

@kaaaaaaang kaaaaaaang added this to the v1.14.0 milestone Nov 8, 2023
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 9, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-09 08:04:55.212067129 +0000 UTC m=+3717892.799177275: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 9, 2023
@ti-chi-bot ti-chi-bot bot merged commit ef3382f into pingcap:master Nov 9, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade go-sql-driver/mysql version to v1.7.1
4 participants