Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix tiflash uptime #2227

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested review from breezewish and srstack July 13, 2023 08:47
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Patch coverage: 46.67% and project coverage change: -0.18 ⚠️

Comparison is base (c2ae2f6) 56.20% compared to head (b4ba19e) 56.02%.

❗ Current head b4ba19e differs from pull request most recent head d9d866a. Consider uploading reports for the commit d9d866a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2227      +/-   ##
==========================================
- Coverage   56.20%   56.02%   -0.18%     
==========================================
  Files         320      320              
  Lines       33683    33685       +2     
==========================================
- Hits        18931    18870      -61     
- Misses      12489    12547      +58     
- Partials     2263     2268       +5     
Flag Coverage Δ
cluster 45.06% <46.67%> (-0.19%) ⬇️
dm 25.98% <0.00%> (-0.05%) ⬇️
playground 15.70% <ø> (-0.02%) ⬇️
tiup 15.94% <ø> (-0.02%) ⬇️
unittest 22.69% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/check.go 47.61% <0.00%> (ø)
pkg/cluster/operation/systemd.go 61.70% <42.31%> (-24.66%) ⬇️
pkg/cluster/manager/display.go 51.17% <100.00%> (+0.45%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 13, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-13 09:39:12.007036942 +0000 UTC m=+584043.777375642: ☑️ agreed by kaaaaaaang.

@ti-chi-bot ti-chi-bot bot added the approved label Jul 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit fe954e6 into pingcap:master Jul 13, 2023
16 checks passed
kaaaaaaang pushed a commit that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't display tiflash uptime
3 participants