Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy, config: add config graceful-close-conn-timeout #400

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #399

Problem Summary:
On the cloud, NLB takes around 90s to mark TiProxy offline after TiProxy shuts down the HTTP port. During this process, new connections are denied.

What is changed and how it works:

  • Only reject new connections after graceful-wait-before-shutdown, not before
  • Add a configuration graceful-close-conn-timeout. After graceful-wait-before-shutdown, reject new connections and close connections that have finished transactions, until graceful-close-conn-timeout ends

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox November 15, 2023 10:18
@ti-chi-bot ti-chi-bot bot added the size/L label Nov 15, 2023
Copy link

ti-chi-bot bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 16, 2023
Copy link

ti-chi-bot bot commented Nov 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-16 02:57:03.031168071 +0000 UTC m=+4304220.618278200: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Nov 16, 2023
@djshow832
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit d148588 into pingcap:main Nov 16, 2023
8 of 9 checks passed
@djshow832 djshow832 deleted the graceful_down branch November 16, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance graceful shutdown procedure
2 participants